Add capability to create module users #354
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThatsMrTalbot
force-pushed
the
feat-redisuser
branch
3 times, most recently
from
7141716 to
fcb43d3
Compare
ThatsMrTalbot
force-pushed
the
feat-redisuser
branch
from
fcb43d3 to
aeb9d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new RedisUser type that wraps the native "RedisModuleUser" type as well as functions to set the ACL on that user.
It also adds methods to the context to authenticate a client using the created RedisUser. This is the foundation for building Redis modules that can do user management (I also would like to implement a solution that wraps RedisModule_RegisterAuthCallback when that is released).
I updated the acl example and tests with the new functionality.
Note:
This is my first real play with Rust so any feedback is appreciated.