Fixes to units for some training reactions and depositories #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The conversions are correct, thanks for fixing this. Let me know once the NIST is fixed. |
The rule was creating rates more than 10 orders of magnitude lower than anything else in the family. It has a reference, but we were unable to find the reaction in the reference.
alongd
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The evaluateKinetics.py testing script was used to discover training reactions/rules that had very bad comparisons with NIST depository or Leave one out cross validation.
In this PR, the incorrect rates in the H-abstraction family were fixed. Most of them were from incorrect recording of the A-factor.