The JetSurF libraries were corrected for [C], [CH], [CH2], [OH] #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally I mistakenly named these libraries `0.2`, where infact they are version `2.0`. The libraries names were corrected now as well. Main changes in this commit are: - The AdjLists of [C] were corrected to a multiplicity 3 instead of 5 (see issue #171) - The AdjLists of [CH] were corrected to a multiplicity 2 instead of 4 (see issue #172) - The representation of CH2 and CH2(S) was correct and wasn't changed - Reactions of `[CH]*` and `[OH]*` (which currently cannot be represented in RMG) were added as a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I mistakenly named these libraries with the suffix
0.2, where in fact they are version2.0.The libraries names were corrected now as well.
Main changes in this commit are:
[CH]*and[OH]*(which currently cannot be represented in RMG) were added as a comment