Skip to content

update ipynb which uses generateThermoData #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2016
Merged

update ipynb which uses generateThermoData #119

merged 1 commit into from
Jul 28, 2016

Conversation

KEHANG
Copy link
Member

@KEHANG KEHANG commented Jul 28, 2016

since spec.generateThermoData is replaced by getThermoData, this PR makes sure ipynb calling this old method can function properly.

@mention-bot
Copy link

@KEHANG, thanks for your PR! By analyzing the annotation information on this pull request, we identified @connie to be a potential reviewer

@connie connie merged commit cb7ecc5 into master Jul 28, 2016
@KEHANG KEHANG deleted the fix_ipynb branch January 20, 2017 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KEHANG @mention-bot @connie