fix: replace gas-based immutability check with direct storage slot check #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50
Summary
The current tests for
ContractImmutable
check immutability indirectly by measuring deployment gas.Since deployment gas can vary depending on the environment, this may cause the tests to fail even when
value
is correctly declared asimmutable
.Changes
value
does not occupy a storage slot.vm.load
to verify that slot0
is empty, while still asserting the correct runtime value.Benefits
Example