Fix PriceIsRightTest fuzzing issue #48
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Fix fuzzing in
PriceIsRightTest
Closes: #47 #46
What changed
vm.assume(amount <= 10 ether)
vm.deal(address(this), amount + 1 ether)
)1 ether
should succeed, everything else should revertWhy
The old fuzz test failed because Foundry would generate massive values for
amount
that couldn’t even be sent asmsg.value
.This caused the revert to happen before reaching the contract, making the test misleading.
Now, fuzzing is limited to a realistic range, and the contract always has enough ETH to pay for the call.
This way the test actually checks the intended logic:
1 ether
is sentHow to test
Run:
forge test
Expected:
0–10 ether
range