Skip to content

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented Aug 28, 2025

Summary

  • discord.Client

    • max_messages, proxy, proxy_auth, shard_id, shard_count, status, activity, allowed_mentions, max_ratelimit_timeout, and connector can be None
  • commands.Bot

    • owner_id and owner_ids can be None
  • commands.Cog

    • Remove the Unpack + CogKwargs
  • commands.Command

    • help, brief, and usage can be None
    • aliases can be a tuple too
  • commands.HelpCommand

    • verify_checks and dm_help can be None
  • commands.HybridGroup

    • Added missing case_insensitive kwarg
    • Fixed type of fallback being Union[str, app_commands.locale_str] instead of Optional[str]
    • Added missing fallback_locale kwarg with a type of Optional[app_commands.locale_str]

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Rapptz
Copy link
Owner

Rapptz commented Aug 29, 2025

My gut feeling says to remove the Unpack usage from CogMeta in general but I don't know.

@Soheab Soheab marked this pull request as ready for review September 3, 2025 11:11
@Soheab
Copy link
Contributor Author

Soheab commented Sep 3, 2025

My gut feeling says to remove the Unpack usage from CogMeta in general but I don't know.

It has been removed.

@Rapptz Rapptz merged commit a2a2281 into Rapptz:master Sep 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants