-
Notifications
You must be signed in to change notification settings - Fork 12
Improve reading experiments stored in multiple files #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 15307117181Details
💛 - Coveralls |
We were repeating ourselves, and that became a problem with complex strategies for combining files
Assume that the first one is correct, infer the remainder
I'm a little confused... don't we require the timestamp to be provided in UNIX format (meaning however many seconds since like 1970 or whatever?)
It seems like we just print something if that is the case. Should we raise an error, or a warning, or something a bit more severe? I'm not sure I understand some of the other modifications, but otherwise it looks fine to me. Would recommend another pair of eyes to take a look, seeing as I really don't think I am the best person to review some of these changes... |
That's the requirement for our file formats. The MACCOR files we're reading are more relaxed. They'll either give you "DD/MM/YYYY HH:MM:SS" or just "HH:MM:SS" with the start date listed in the top. Check out https://github.com/ROVI-org/battery-data-toolkit/blob/day-rollover/tests/files/maccor_example.002
That's right. I opted to make these "Checker" tools return a string and leave it up to the whomever uses them to decide whether it should be warning/error/exception. |
We currently assume no time elapses between multiple testing files. This PR uses the timestamps available in MACCOR output files to infer the length of a rest period.
Detecting the timestamp is complicated because some MACCOR files do not list the date along with the timestamp. We can infer it from cross-referencing with the "test time" column.
I also refactored so that the logic for making the test_time consistent between files part of a super class for all cycler parsers to avoid duplication between subclasses.
Also provides a utility for verifying that the
time
andtest_time
columns are consistent.