Rename "corr_id" to "stack_id" in Perfetto annotations to match new n… #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aming in schema. Signed-off-by: David Galiffi <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR renames correlation ID references to stack ID throughout the rocprofiler SDK integration code to better reflect their semantic meaning. The changes update both variable names and perfetto annotation labels while maintaining the same underlying data (correlation_id.internal).
Key Changes
- Variable names changed from
_corr_idto_stack_idin kernel dispatch and memory copy tracing functions - Perfetto annotation labels updated from
"corr_id"to"stack_id"in tracing callbacks - All changes consistently rename without altering functionality or data flow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mradosav-amd
approved these changes
Oct 31, 2025
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Rename "corr_id" to "stack_id" in Perfetto annotations to match new naming in schema
Technical Details
Renaming string in Perfetto annotations
Test Plan
Run ctests. Verify that string has been renamed in Perfetto.
Test Result
Submission Checklist