Skip to content

Conversation

@TomSang
Copy link
Contributor

@TomSang TomSang commented Oct 29, 2025

Fix a typo.
Remove unnecessary log.

Motivation

see above

Technical Details

in os_posix.cpp

Test Plan

all need pass

Test Result

pass

Submission Checklist

Fix a typo.
Remove unnecessary log.
Copilot AI review requested due to automatic review settings October 29, 2025 22:15
@TomSang TomSang requested a review from a team as a code owner October 29, 2025 22:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes redundant error logging and fixes a format string bug in the NUMA node affinity code. The change eliminates a duplicate error message to stderr while correcting the ClPrint call to properly format a std::string parameter.

  • Removed redundant std::cerr error output
  • Fixed format string bug by adding .c_str() to convert std::string to C-string for printf-style formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@b-sumner b-sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants