Ignore unused parameter for boost libraries #1605
Open
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR suppresses compiler warnings for unused parameters from the Boost Math library header and adds a missing newline at the end of a test file.
- Adds
#pragma GCC diagnosticdirectives to suppress-Wunused-parameterwarnings when includingboost/math/special_functions.hpp - Restores the newline at the end of
trig_funcs.cc
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/hip-tests/catch/unit/math/trig_funcs.cc | Wraps Boost Math header with pragma directives to suppress unused parameter warnings and adds trailing newline |
| projects/hip-tests/catch/unit/math/special_funcs.cc | Wraps Boost Math header with pragma directives to suppress unused parameter warnings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The version of Boost, used by theRock build system(1.87.0), is breaking our build due to the unused variables. This PR fixes that compile error.
Technical Details
This PR disables unused params check for specific boost headers using pragma directives
Test Plan
Tests should be successfully compiling with Boost 1.87.0 and consequently pass.
Test Result
Test compilation is fixed, waiting for PSDB to pass.
Submission Checklist