Skip to content

rocr: Return error on signal alloc failure (#1310) #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/rocm-rel-7.1
Choose a base branch
from
+3 −0
Open

rocr: Return error on signal alloc failure (#1310) #1603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions projects/rocr-runtime/runtime/hsa-runtime/core/runtime/hsa_ext_amd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,9 @@ hsa_status_t hsa_amd_signal_create(hsa_signal_value_t initial_value, uint32_t nu
ret = new core::InterruptSignal(initial_value);
}

if (ret == nullptr)
return HSA_STATUS_ERROR_OUT_OF_RESOURCES;

*hsa_signal = core::Signal::Convert(ret);
return HSA_STATUS_SUCCESS;
CATCH;
Expand Down
Loading