pytest fixes, added ingore list and deselect test during pytest colle… #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ction stage
(cherry picked from commit 42b19d0)
Motivation
This PR fixes pytest "test collection" and execution mechanism. Test are collected in stage one after filtering out unwanted tests., and passed to 2nd stage for execution.
However Multigpu tests are not following test collection mechanism. It directly run tests files (.py) with mutligpu parameterized tests variants.
In this case, a python dictionary is introduced that list all unwanted tests in corresponding test file. this list is used to filter out unwanted test list during test-file execution.
Technical Details
Test Plan
JAX Unit test
Test Result
PASSED
Submission Checklist