Jax tests skip for v071 #145
Conversation
| --deselect jax/tests/qdwh_test.py::QdwhTest::testQdwhWithDynamicShape | ||
| --deselect jax/tests/qdwh_test.py::testQdwhWithRandomMatrix | ||
| #failed in rocm-v0.7.1 | ||
| --deselect jax/tests/sparsify_test.py::SparsifyTest::testSparseMul |
There was a problem hiding this comment.
are all of the variations of these tests failing? Typically some cases only fail such as a postfix number index for each test instance.
There was a problem hiding this comment.
currently our skipped recipe is not working as per our expectation, nothing is skipped listed in this file,
I added parameterized tests initially but changed to based on file.
There was a problem hiding this comment.
See this comment #145 (comment) @zahiqbal
| #failed in rocm-v0.7.1 | ||
| --deselect jax/tests/sparsify_test.py::SparsifyTest::testSparseMul | ||
| --deselect jax/tests/sparsify_test.py::SparsifyTest::testUnaryOperationsNonUniqueIndices | ||
| --deselect jax/tests/sparsify_test.py::SparsifyTracerTest::testSparseDiv |
There was a problem hiding this comment.
Also is pytest able to find these tests properly to skip them? Typically if you are not giving the full test name (such as jax/tests/pallas/ops_test.py::OpsTest::test_approx_tanh0, pytest does not find the module name properly). If you want to completely skip all the variations of jax/tests/pallas/ops_test.py::OpsTest::test_approx_tanh tests you will need to use the -k argument when running pytest. I think for skip.ini, this behavior may be same or different.
So as a summary, I want to learn if these were verified as skipped in the tests.
zahiqbal
force-pushed
the
rocm-jaxlib-v0.7.1
branch
3 times, most recently
from
bf6f6e2 to
42b19d0
Compare
3 participants
Motivation
captured a full list of failed test case on rocm-0.7.1. compared these failures on rocm6.0 branch to figure out these are real failures.
Technical Details
Test Plan
Jax unit test plan
Test Result
246 test failed in total, corresponding test files are marked as skipped.
Submission Checklist