-
Notifications
You must be signed in to change notification settings - Fork 67
MAGMA wheel and source torch build integration #2233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rocm7.0_internal_testing
Are you sure you want to change the base?
Conversation
Jenkins build for 769e1996b6a639e1de0aec3425ce732f6dfc1e5b commit finished as FAILURE |
caffe2/CMakeLists.txt
Outdated
target_link_libraries(torch_cuda_linalg PRIVATE torch::magma) | ||
elseif(USE_ROCM) | ||
target_link_libraries(torch_cuda_linalg PRIVATE __rocm_magma) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra newline
cmake/Dependencies.cmake
Outdated
else() | ||
message(STATUS "MAGMA not found. Compiling without MAGMA support") | ||
caffe2_update_option(USE_MAGMA OFF) | ||
find_package(MAGMA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
Jenkins build for 769e1996b6a639e1de0aec3425ce732f6dfc1e5b commit finished as FAILURE |
cmake/External/magma.cmake
Outdated
INSTALL_DIR ${__MAGMA_INSTALL_DIR} | ||
CONFIGURE_COMMAND "" | ||
BUILD_COMMAND "" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra newline
INSTALL_COMMAND ${CMAKE_COMMAND} -E copy_directory <SOURCE_DIR>/include/ <INSTALL_DIR>/include/magma | ||
COMMAND ${CMAKE_COMMAND} -E copy <SOURCE_DIR>/lib/libmagma.so <INSTALL_DIR>/lib | ||
|
||
BUILD_BYPRODUCTS <INSTALL_DIR>/lib/libmagma.so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra newline
Jenkins build for 19a5cac1e8057ac967d32d870c99aaa3af44d8d6 commit finished as FAILURE |
Added a magma installer to the ROCm Torch CMake build process.