Skip to content

MAGMA wheel and source torch build integration #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: rocm7.0_internal_testing
Choose a base branch
from

Conversation

willpear-amd
Copy link

Added a magma installer to the ROCm Torch CMake build process.

@willpear-amd willpear-amd self-assigned this Jun 4, 2025
@jithunnair-amd jithunnair-amd changed the base branch from main to rocm6.5_internal_testing June 4, 2025 13:20
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jun 6, 2025

Jenkins build for 769e1996b6a639e1de0aec3425ce732f6dfc1e5b commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@jithunnair-amd jithunnair-amd changed the base branch from rocm6.5_internal_testing to rocm7.0_internal_testing June 10, 2025 19:48
target_link_libraries(torch_cuda_linalg PRIVATE torch::magma)
elseif(USE_ROCM)
target_link_libraries(torch_cuda_linalg PRIVATE __rocm_magma)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra newline

else()
message(STATUS "MAGMA not found. Compiling without MAGMA support")
caffe2_update_option(USE_MAGMA OFF)
find_package(MAGMA)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jun 10, 2025

Jenkins build for 769e1996b6a639e1de0aec3425ce732f6dfc1e5b commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

INSTALL_DIR ${__MAGMA_INSTALL_DIR}
CONFIGURE_COMMAND ""
BUILD_COMMAND ""

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra newline

INSTALL_COMMAND ${CMAKE_COMMAND} -E copy_directory <SOURCE_DIR>/include/ <INSTALL_DIR>/include/magma
COMMAND ${CMAKE_COMMAND} -E copy <SOURCE_DIR>/lib/libmagma.so <INSTALL_DIR>/lib

BUILD_BYPRODUCTS <INSTALL_DIR>/lib/libmagma.so
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra newline

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jun 11, 2025

Jenkins build for 19a5cac1e8057ac967d32d870c99aaa3af44d8d6 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants