Skip to content

Conversation

@GeneDer
Copy link
Member

@GeneDer GeneDer commented Oct 2, 2025

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

gulsumgudukbay and others added 6 commits September 22, 2025 22:32
* Revert "use Pytree as base type in nnx_wrappers"

This reverts commit 8840296.

Note: This commit should be reverted when flax version is upgraded
to anything >= 0.11.0. Right now, JAX 0.6.0 does not support any flax
version >= 0.10.7, hence this commit is required as flax started
exposing PyTree after 0.11.0.
@GeneDer GeneDer marked this pull request as ready for review October 10, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants