Implement pytest for 07_gemm_all_scatter/gemm_all_scatter.py with import path fixes #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements comprehensive pytest coverage for the
07_gemm_all_scatter/gemm_all_scatter.py
example, following the established testing patterns in the repository.Changes Made
Added
tests/examples/test_gemm_all_scatter.py
with two main test functions:test_gemm_all_scatter()
- Comprehensive parametrized test covering:torch.float16
,torch.bfloat16
,torch.float32
test_gemm_all_scatter_minimal()
- Basic functionality test with minimal dimensions to ensure the kernel works correctly in any MPI environment.Implementation Details
test_load_bench.py
sys.path
to resolve relative imports in dynamically loaded modulesvalidate_gemm()
function fromexamples/common/validation.py
Bug Fixes
Fixed ImportError that occurred during test collection when dynamically importing
matmul_wrapper.py
. The issue was that modules in the07_gemm_all_scatter
example contain relative imports fromexamples.common
that weren't resolving correctly when imported viaimportlib.util
. The fix adds the repository root tosys.path
before module import to ensure proper resolution of these dependencies.The tests will be automatically discovered and executed by the existing CI infrastructure that runs
mpirun -np <ranks> python -m pytest tests/examples/test_*.py
.Fixes #61.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.