Skip to content

Adding target for bumping operator version #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-v1.2.1
Choose a base branch
from
Open

Adding target for bumping operator version #167

wants to merge 1 commit into from

Conversation

nikhilsk
Copy link
Contributor

@nikhilsk nikhilsk commented May 5, 2025

No description provided.

@nikhilsk nikhilsk marked this pull request as ready for review May 5, 2025 07:38
yansun1996
yansun1996 reviewed May 5, 2025
View reviewed changes
Copy link
Member

@yansun1996 yansun1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have one single PROJECT_VERSION variable, what's the reason to introduce another version variable ?

Maintaining one single variable would be much more simpler.

@nikhilsk
Copy link
Contributor Author

nikhilsk commented May 6, 2025

It's not a new version variable @yansun1996
The idea is to create a target which takes an OLD version as a parameter and convert all those versions to a new PROJECT_VERSION .
I have enhanced the existing update-version target and have added more place-holders where the versioning has to be bumped up

@nikhilsk nikhilsk requested a review from yansun1996 May 6, 2025 19:01
@nikhilsk nikhilsk requested a review from sajmera-pensando May 15, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yansun1996 yansun1996 Awaiting requested review from yansun1996

@sajmera-pensando sajmera-pensando Awaiting requested review from sajmera-pensando

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikhilsk @yansun1996