defined compile time macro for warp size with ROCm 7 #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Defined compile time macro for warp size with ROCm 7.
Technical Details
Added the macro in
ops.hip
andkernel.hip
wherewarpSize
is being defined. Without the fix,warpSize
won't be defined.Reference:
Test Plan
Build the project with new changes on both ROCm 6.4.3 and ROCm 7.0.0. Run the pytest suite on both versions.
Test Result
pytests passed on both ROCm versions with changes added.
Submission Checklist