fix repeated unnecessary device check #1221
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Cache results of device/arch detection to avoid repeated and costly runtime queries.
- Add functools.lru_cache to get_arch and get_device
- Import lru_cache and configure cache size to 8
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Let me fix the lint and the copilot suggestion, I think it's acc correct |
b8zhong
force-pushed
the
remove-device-check
branch
from
31a3a27 to
ec0f7d0
Compare
|
@valarLip Thanks for reviewing. I fixed the lint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
It seems to be spending a non trivial time in CUDA & it generally should be cached. We assume up to 8 devices.
Submission Checklist