Skip to content

Conversation

@subodh-dubey-amd
Copy link
Contributor

@subodh-dubey-amd subodh-dubey-amd commented Dec 4, 2025

Motivation

Extends PyTorch build support to include Python 3.10, enabling compatibility for users who require Python 3.10 in their environments.

Technical Details

  • Updated GitHub workflows (release_portable_linux_pytorch_wheels.yml, release_windows_pytorch_wheels.yml) to include Python 3.10 in the build matrix
  • Updated documentation (RELEASES.md, external-builds/pytorch/README.md) to reflect Python 3.10+ support
  • No changes needed for manylinux build configuration (already supports cp310) or CMake (minimum Python 3.9)

Test Plan

CI/CD pipelines will be build and test PyTorch wheels for Python 3.10 alongside existing versions (3.11, 3.12, 3.13).
https://github.com/ROCm/TheRock/actions/runs/19939030860
https://github.com/ROCm/TheRock/actions/runs/19939030860/job/57171706110

Test Result

https://github.com/ROCm/TheRock/actions/runs/19939030860
https://github.com/ROCm/TheRock/actions/runs/19939030860/job/57171706110

Submission Checklist

@subodh-dubey-amd subodh-dubey-amd force-pushed the subodh-dubey-amd/pytorch-py3.10 branch 2 times, most recently from 3ee5cb2 to af5ae5c Compare December 5, 2025 08:20
@subodh-dubey-amd subodh-dubey-amd self-assigned this Dec 5, 2025
@subodh-dubey-amd subodh-dubey-amd marked this pull request as ready for review December 5, 2025 08:39
- Updated the supported Python versions in RELEASES.md and external-builds/pytorch/README.md to include Python 3.10.
- Modified GitHub workflows for portable Linux and Windows PyTorch wheels to reflect the updated Python version matrix.

This change ensures compatibility with Python 3.10 across relevant documentation and CI configurations.
@subodh-dubey-amd subodh-dubey-amd force-pushed the subodh-dubey-amd/pytorch-py3.10 branch from af5ae5c to e3f34de Compare December 5, 2025 15:08
@kiran-thumma
Copy link
Contributor

#2449 Linked issue for adding support for python 3.10 to support all the pytorch version.

Copy link
Contributor

@kiran-thumma kiran-thumma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 89 to +90
matrix:
python_version: ["3.11", "3.12", "3.13"]
python_version: ["3.10", "3.11", "3.12", "3.13"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will increase our testing surface area. I've started some discussions about whether we always want to run tests on all python versions or if we can choose a subset of python versions to run (regular) tests for.

It's about 20-120 minutes of test time per python version, per GPU family, per PyTorch version. That's with our current set of tests, and we might expand the set of tests later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

4 participants