Update project support table for torch codec, scatter and sparse #2405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
reviewed
Dec 3, 2025
Member
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
A few thoughts about phrasing. Also please fix the pre-commit check failures:
external-builds/pytorch/README.md
Outdated
Comment on lines
32
to
33
| > 1. Supported: Official packages are distributed by the ROCm team | ||
| > 2. Nightly: Included in TheRock-based packages, built nightly |
Member
There was a problem hiding this comment.
One extra distinction here is
| package index domain | description |
|---|---|
| https://download.pytorch.org/ | official upstream releases with instructions at https://pytorch.org/get-started/locally/ |
| https://repo.amd.com/rocm/ | stable releases distributed by AMD and built by TheRock (technically built in https://github.com/ROCm/rockrel) |
| https://rocm.nightlies.amd.com/ | nightly releases distributed by AMD and built by TheRock |
I think in these docs we should focus on just what TheRock builds, though it is worth mentioning
- Which packages are compatible with what we distribute (torch-scatter, torch-sparse)
- Which packages are not yet compatible and are either on or off our roadmap to support (e.g. https://github.com/ROCm/apex)
Contributor
Author
There was a problem hiding this comment.
Added in the suggested sections. Let me know if this is what you were looking for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update project status for
as described in #2346
Technical Details
N/A
Test Plan
There already seems to be some hip/ROCm enablement in the upstream libraries (ex https://github.com/rusty1s/pytorch_scatter/blob/master/setup.py#L75-L79). Will try to build and test these but for the short term, updating the project support page to call out them out specifically.
Test Result
N/A
Submission Checklist