Added conditional attribute requirement to Object Template #32
+158
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshryane
requested review from
MiguelAHM,
fmurodov,
isvonja and
maggarwal13
as code owners
|
Wait for next Whois release before deploying (needs to be aligned with code changes) |
MiguelAHM
reviewed
Oct 13, 2025
|
|
||
| **The RIPE Database contains objects formatted according to the Routing Policy Specification Language (RPSL), which has a set of syntax rules you have to comply with when creating, updating or deleting objects. In addition, the RIPE NCC enforces certain business rules to ensure data integrity and registry accuracy. This document gives an overview of all current business rules.** | ||
|
|
||
| The object template lists attributes with a conditional requirement, which will be mandatory ot optional depending on the Database business rules. |
There was a problem hiding this comment.
typo:
will be mandatory or optional not op
There was a problem hiding this comment.
should we consider to add a reference to businessRules interface in GitHub repository?
MiguelAHM
approved these changes
Oct 13, 2025
|
approve with minor comments |
MiguelAHM
reviewed
Oct 13, 2025
|
|
||
| | **Applies To Object Type** | **On Action** | **Business Rule** | | ||
| |--------------------------------------|----------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | **all** | Create | An object cannot be created if it already exists. The creation will fail if another object of the same type and with the same primary key is already present in the RIPE Database. | |
There was a problem hiding this comment.
Should we add a new rule for Geofeed or prefixlen?
Saying that if the geofeed/prefixlen is already in the remark it is not allowed the creation?
There was a problem hiding this comment.
I think that they shouldn't be "conditional" because you still can create a geofeed/prefixlen with different value than the remark and still be OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion on the Database Working Group [1], implement the conditional attribute requirement.
A conditional attribute may be mandatory or optional, depending on database business rules [2].
Related to RIPE-NCC/whois#1881
[1] https://mailman.ripe.net/archives/list/[email protected]/thread/DN3NRUOWEHHGVZUL7WLEGSEVKOIZVAV7/
[2] https://docs.db.ripe.net/Database-Support/Database-Business-Rules