Skip to content

Conversation

@MiguelAHM
Copy link
Contributor

@MiguelAHM MiguelAHM commented Oct 13, 2025

A boolean mandatory: true or false is being used for displaying those attributes that are required when creating/updating an object
reading the RFC https://datatracker.ietf.org/doc/html/rfc2622 makes sense to me. Mandatory: true will be when we know that the attribute is required. Mandatory: false will be when the attribute is optional or conditional.

If we decide to change this, we should replicate the business logic when conditional (just to know if we should display the attribute or not as we do with mandatory - to know if that conditional is mandatory or not).

I don't think this is needed because the user could always add the "conditional" attribute if needed, when errors are thrown from backend.

We just need to make sure that the Condition is display in the object template, so the user can know before hand which is a conditional attribute. For that, it is enough just adding the whois dependency because the templates are being taken from whois dependency.

@eshryane
Copy link
Member

We don't need to replicate the Whois business logic. If a conditional attribute is not valid then Whois will return an error and the web application will display it.

@eshryane
Copy link
Member

DO NOT merge until after the next Whois release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants