Add validation for SELECT query return formats #247
+45
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds validation to prevent semantically incorrect usage of RDF return formats with SELECT queries in SPARQLWrapper. SELECT queries return result sets, not RDF graphs, so requesting RDF formats like RDF/XML, Turtle, N3, or JSON-LD is semantically incorrect and can lead to confusing server errors.
This PR is a compilation of #220 #218 solutions for #190 issue
Changes Made
Core Changes
SPARQLWrapper/Wrapper.py:unsupportedReturnTypesForSelectQueries = [RDF, RDFXML, TURTLE, N3, JSONLD]_getAcceptHeader()method to raiseValueErrorwhen RDF formats are used with SELECT queriesTest Coverage
test/test_wrapper.py:testSelectQueryWithRDFFormatsRaisesValueError: Tests that all RDF formats raise appropriate ValueErrortestSelectQueryWithValidFormatsWorks: Ensures valid formats (XML, JSON, CSV, TSV) work correctlyMotivation
Breaking Changes
ValueErrorinstead of sending invalid requests to the server.Testing
Example
Error message:
TURTLE is not a valid return format for SELECT queries. Supported formats include: json, xml, csv, tsvRelated Issues
This addresses the semantic issue where users could request inappropriate return formats for SELECT queries, which could lead to confusing server responses or errors.