Make the mod buildable #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n of loom and kotlin jvm (following the version used for Ledger)
…lared in build.gradle)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to test the MariaDB changes and as they are not published on Modrinth, I cloned the mod and tried building in local for myself.
When I did that, I saw that the Gradle version was outdated (8.1.1 while the version of
fabric-loomrequested Gradle 8.9 or above)I updated to use same
fabric-loomand Gradle version as latest version of Ledger.After that, I had an other issue with the Kotlin JVM, I update to the same version as Ledger too.
In the same time, I changed the target version of the Ledger to 3.10 to be accurate with the main branch of it.
I was able to execute Gradle, but now when I tried to build, it told me that it was missing
konfandsqlite-jdbc. The fact they were missing as dependencies was very strange as they are used but, yes, they aren't declared anywhere, so I added both to thebuild.gradletoo.