-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Prepare 2.2.0 release #14995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 2.2.0 release #14995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
releasenotes/notes/2.2/add-new-mcx-noaux-method-6f38c3cd3708df3c.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/2.2/add-new-mcx-noaux-method-6f38c3cd3708df3c.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/2.2/add-new-mcx-noaux-method-6f38c3cd3708df3c.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/2.2/cbindgen-usize-to-size_t-544294518fdfcbb0.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/2.2/parameterized_target_c-9c9a4ad2915c2348.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/2.2/unitary_synthesis_c-cea75710a20cb4dd.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/2.2/elide_permutations_c-e2c66e8cd42a1afd.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/2.2/rm-diag-gates-before-meas-c-9bb9f2b5490cf0a2.yaml
Outdated
Show resolved
Hide resolved
cb4cee2
to
ce23736
Compare
============ | ||
|
||
The :c:func:`qk_transpile` function exposes Qiskit's tranpsiler (:py:mod:`qiskit.transpiler`) to C. | ||
The :cpp:func:`qk_transpile` function lets C access the Qiskit tranpsiler (:py:mod:`qiskit.transpiler`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why cpp
over c
? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly because the docs are not set up right, and this is the only way it links to it.
features_c: | ||
- | | ||
The ``QkTarget`` type is now able to represent targets that support | ||
The ``QkTarget`` type can now represent targets that support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sphinx annotations are a bit inconsistent right now, e.g. why do we add c(pp):func
to functions but not c:struct
to the structs (same for enums)? Was there any update on the docs team if adding the annotation could enable links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only reason why I don't add it here is because it doesn't link to the struct's page, either with :c:struct:
or :cpp:struct:
.
The OpenQASM Features entry in the release notes refers to the |
One or more of the following people are relevant to this code:
|
Since this is now marked as Ready for Review, just a reminder that we still need to update the version numbers and remove release notes that were already covered in the 2.1 patches |
e7903c5
to
7fb19ac
Compare
- Fix incorrect argument in `qk_transpile` function. - Fixed more missed links from the c-api, temporarily linked with `:cpp:func:`. - Other small tweaks.
Co-authored-by: Rebecca Dimock <[email protected]>
- Remove all of the standalone C API pass release notes.
Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: Eli Arbel <[email protected]>
7fb19ac
to
016c399
Compare
releasenotes/notes/2.2/add-c-standalone-passes-207be980c30c3fe9.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/2.2/cbindgen-usize-to-size_t-544294518fdfcbb0.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/2.2/cbindgen-usize-to-size_t-544294518fdfcbb0.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/2.2/fix-qk-get-inst-leak-bb2e2299814515c3.yaml
Outdated
Show resolved
Hide resolved
For more information about the above and other changes made, please see the release notes below | ||
and review the updated documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included it since we mentioned it in the last 2.1 prelude
Co-authored-by: Matthew Treinish <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this LGTM now, I pushed up a small commit to fix some small things. I could probably continue to nitpick for a while so we should just move forward with this. If we spot anything else major in the release notes we can always circle back and fix it as part of the 2.2.1 bugfix release.
Matthew found formatting issue
Summary
The following PR moves any new release notes to the 2.2 folder, fixes the format and writing of the docstrings, and changes versioning to 2.2.0 for the final release.
Tasks (unordered)