docs(transpiler-plugins): fix layout plugin example for v2.1.2 (#14985) #14991
+13
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#14985) Fixes Qiskit#14985 issue. Updates the example under `qiskit.transpiler.preset_passmanagers.plugin` so it runs on Qiskit SDK v2.1.2. - Replace `PassManager.append(..., condition=...)` with `ConditionalController`. - Remove usage of `backend_properties` from `PassManagerConfig`. - Pass `target=pass_manager_config.target` to `VF2Layout`. - Add the missing comma in `max_trials=...`. - Guard property_set lookups with `.get(...)` and check against `VF2LayoutStopReason.SOLUTION_FOUND`. Tested with `generate_preset_pass_manager(..., layout_method="vf2lite")` at `optimization_level=1..3` on SDK v2.1.2.
qiskit-bot
added
the
Community PR
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
|
|
Pull Request Test Coverage Report for Build 18169540117Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jakelishman
approved these changes
Oct 1, 2025
jakelishman
added
documentation
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
… (#14991) * docs(transpiler-plugins): fix layout plugin example for v2.1.2 (#14985) Fixes #14985 issue. Updates the example under `qiskit.transpiler.preset_passmanagers.plugin` so it runs on Qiskit SDK v2.1.2. - Replace `PassManager.append(..., condition=...)` with `ConditionalController`. - Remove usage of `backend_properties` from `PassManagerConfig`. - Pass `target=pass_manager_config.target` to `VF2Layout`. - Add the missing comma in `max_trials=...`. - Guard property_set lookups with `.get(...)` and check against `VF2LayoutStopReason.SOLUTION_FOUND`. Tested with `generate_preset_pass_manager(..., layout_method="vf2lite")` at `optimization_level=1..3` on SDK v2.1.2. * Fix lint error in plugin.py docstring (line too long) * Fix spacing --------- Co-authored-by: Jake Lishman <[email protected]> (cherry picked from commit cbe1f20)
Merged
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
… (#14991) (#15103) * docs(transpiler-plugins): fix layout plugin example for v2.1.2 (#14985) Fixes #14985 issue. Updates the example under `qiskit.transpiler.preset_passmanagers.plugin` so it runs on Qiskit SDK v2.1.2. - Replace `PassManager.append(..., condition=...)` with `ConditionalController`. - Remove usage of `backend_properties` from `PassManagerConfig`. - Pass `target=pass_manager_config.target` to `VF2Layout`. - Add the missing comma in `max_trials=...`. - Guard property_set lookups with `.get(...)` and check against `VF2LayoutStopReason.SOLUTION_FOUND`. Tested with `generate_preset_pass_manager(..., layout_method="vf2lite")` at `optimization_level=1..3` on SDK v2.1.2. * Fix lint error in plugin.py docstring (line too long) * Fix spacing --------- (cherry picked from commit cbe1f20) Co-authored-by: Ricard Santiago Raigada García <[email protected]> Co-authored-by: Jake Lishman <[email protected]>
aaryav-3
pushed a commit
to aaryav-3/qiskit
that referenced
this pull request
Oct 21, 2025
…t#14985) (Qiskit#14991) * docs(transpiler-plugins): fix layout plugin example for v2.1.2 (Qiskit#14985) Fixes Qiskit#14985 issue. Updates the example under `qiskit.transpiler.preset_passmanagers.plugin` so it runs on Qiskit SDK v2.1.2. - Replace `PassManager.append(..., condition=...)` with `ConditionalController`. - Remove usage of `backend_properties` from `PassManagerConfig`. - Pass `target=pass_manager_config.target` to `VF2Layout`. - Add the missing comma in `max_trials=...`. - Guard property_set lookups with `.get(...)` and check against `VF2LayoutStopReason.SOLUTION_FOUND`. Tested with `generate_preset_pass_manager(..., layout_method="vf2lite")` at `optimization_level=1..3` on SDK v2.1.2. * Fix lint error in plugin.py docstring (line too long) * Fix spacing --------- Co-authored-by: Jake Lishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix documentation example for the transpiler stage plugin in Qiskit SDK v2.1.2.
Details and comments
Fixes #14985.
Docs-only change: updates the example under
qiskit.transpiler.preset_passmanagers.pluginto replacePassManager.append(..., condition=...)withConditionalController, removebackend_properties, passtarget, add the missing comma inmax_trials, and guardproperty_setlookups with.get(...).