-
Notifications
You must be signed in to change notification settings - Fork 545
Fix capture_output
management of logger file descriptors
#3633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er' into default-pyomo-log-handler
Removes the duplicate deprecation autosummary docs to avoid errors from logging output in the docs output strings.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3633 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 888 888
Lines 102347 102363 +16
=======================================
+ Hits 91009 91026 +17
+ Misses 11338 11337 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrmundt
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3210 .
Summary/Motivation:
This resolves an issue with how
capture_output
manages LogHandlers when they appear in LogStreams thatcapture_output
is sending output to, as reported by #3210. The root cause was a subtle interaction between Pyomo's default log handler (an instance ofpyomo.common.log.StdoutHandler
) and the log handler interception used bycapture_output
. In that situation, the default Pyomo LogHandler was resetting the handler'sstream
attribute back to the current value ofsys.stdout
when records were emitted by the handler. This led tocapture_output
trying to fetch and close the wrong file descriptor on exit.This PR makes several changes to resolve this situation
capture_output
to explicitly store the file descriptors they open and not rely on the stream to store the fd for them.StdoutHandler
class to not permanently change the output stream within theemit
/flush
methods.StdoutHandler
and instead now just use a standard streamHndler.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: