Skip to content

[SkillCorner V3] Add support for V3 SkillCorner tracking data #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2025

Conversation

DriesDeprest
Copy link
Contributor

Add support for SkillCorner tracking data version 3 and keeping support for data version 2.

@UnravelSports
Copy link
Contributor

@DriesDeprest I don't think the below generalizes to all versions of JSON.

with open_as_file(raw_data) as raw_data_fp:
        first_line = raw_data_fp.readline().strip()

If I try to load a "structured_data.json" that is stored like below it recognizes only "[" as the first line.

[
    {
        "frame": 0,
        "timestamp": null,
        "period": null,
        "ball_data": {
            "x": null,
            "y": null,
            "z": null,
            "is_detected": null
        },

@koenvo koenvo added this to the 3.17.0 milestone May 13, 2025
@probberechts probberechts merged commit 4f9f46e into PySport:master May 28, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants