code: Retrieve .csv from_url for branches in development/master #251
Conversation
|
|
|
No, |
|
I'll let @lkstrp decide, but it seems like changed line noise to me. |
|
Ah maybe should have read here, before merging #252 As discussed, I am a bit against adding |
| """ | ||
| from . import latest_release | ||
| from . import __version__ |
There was a problem hiding this comment.
We don't like non absolute imports and not adding version.py as discussed is on purpose?
|
|
||
| url: str = "" | ||
| if any(substr in __version__ for substr in ["dev", "post"]): | ||
| # Detect running from a development installation - retrieve data from the HEAD of the |
There was a problem hiding this comment.
With version.py all the git stuff below would also not be needed, is it? Why would you want to retrieve powerplants.csv from an dev branch? Not sure if we wanna have an extra dependency for that
There was a problem hiding this comment.
if the version.py fixes things, then I would be fine to remove.
I was thinking about the case where someone is installing from master and suddenly receiving the wrong powerplants.csv (because it is taken from the tag version).
I guess packaging and shipping the powerplants.csv would be an alternative as well, instead of retrieving it from a semi-hardcoded URL.
There was a problem hiding this comment.
But powerplants.csv is only automatically update per release, so even when installing from master, you would retrieve the same file
There was a problem hiding this comment.
hm, I didn't consider this
There was a problem hiding this comment.
If we don't want to change this, then I guess we can close here
When working on a development branch or with the
masterbranch installed in editable modeuv pip install -e ., the current logic retrievespowerplants.csvfrom the past minor release (not past patch).This PR changes the behavior, such that in case of a development branch or the
masterbranch, the data is always retrieved from the currentHEADof the branch that is on GitHub.Will fail if the branch is not in the
PyPSA/powerplantmatchingrepo in GitHub.Changes proposed in this Pull Request
Checklist
doc.doc/release_notes.rstof the upcoming release is included.