drop the final remaining use of the deprecated pkg_resources module #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Declaring a namespace package has gone through a few revisions. pkg_resources has a version that is heavily deprecated. pkgutil provides a python2/python3 compatible version that is also compatible with native python3 namespaces. https://packaging.python.org/en/latest/guides/packaging-namespace-packages/ pkg_resources is very very deprecated and importing or using it results in deprecation warnings. It's time to move off of it entirely. Fixes: PyFilesystem#577
eli-schwartz
force-pushed
the
pkg-resources-part-2
branch
from
7365022 to
c009996
Compare
tutankalex
added a commit
to tutankalex/python-schematized-config
that referenced
this pull request
Nov 14, 2024
pyfilesystem2 is no longer actively maintained, but it uses a deprecated function, leading to these warnings: ``` python3.11/site-packages/fs/__init__.py:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html ``` see e.g. PyFilesystem/pyfilesystem2#590 fortunately, fsspec and https://github.com/iterative/morefs are sufficient to cover a direct transition
4 tasks
|
Given the deprecation warning suggests pkg_resources will be removed november this year, are we able to renew the push for this again? :) |
|
I haven't given up on this PR by the way -- I am not aware of any issues with it though, so I'm just waiting for someone with commit access to review... |
|
@willmcgugan Can this be reviewed and merged? |
merged both branches in pkg-resources-part-1-and-2 edit: now this also includes #588 |
This comment was marked as outdated.
This comment was marked as outdated.
|
@milahu please see all my pending PRs, not just two of them. There is a third that fixes that in a very different way than the one you propose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaring a namespace package has gone through a few revisions. pkg_resources has a version that is heavily deprecated. pkgutil provides a python2/python3 compatible version that is also compatible with native python3 namespaces.
https://packaging.python.org/en/latest/guides/packaging-namespace-packages/
pkg_resources is very very deprecated and importing or using it results in deprecation warnings. It's time to move off of it entirely.
Fixes: #577
Depends on: #589