Skip to content

Conversation

@rjhorniii
Copy link

This adds the ability to specify stdin as the source.

@rjhorniii
Copy link
Author

Added a fix to deal with .ics sources that do not comply with the RFC rules for line endings. They use "\n" rather than "\r\n". This affects proper handling of continuation lines. The change tolerates either encoding with proper continuation lines.

Copy link
Owner

@PuloV PuloV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explan changes and add tests

p.parsedCalendars = []*Calendar{}
p.parsedEvents = []*Event{}

// buffers the events output chan
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you dropped this?

parsedCalMutex sync.Mutex
inputChan chan string
outputChan chan *Event
bufferedChan chan *Event
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ?

bufferedChan chan *Event
errorsOccured []error
parsedCalendars []*Calendar
parsedEvents []*Event
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ?

p := new(Parser)
p.inputChan = make(chan string)
p.outputChan = make(chan *Event)
p.bufferedChan = make(chan *Event)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants