-
Notifications
You must be signed in to change notification settings - Fork 40
Add stdin as potential input source #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ignored, but no longer interfere with extracting the parameters of interest.
they are not applied to their associated parameters or elements.)
|
Added a fix to deal with .ics sources that do not comply with the RFC rules for line endings. They use "\n" rather than "\r\n". This affects proper handling of continuation lines. The change tolerates either encoding with proper continuation lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explan changes and add tests
| p.parsedCalendars = []*Calendar{} | ||
| p.parsedEvents = []*Event{} | ||
|
|
||
| // buffers the events output chan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you dropped this?
| parsedCalMutex sync.Mutex | ||
| inputChan chan string | ||
| outputChan chan *Event | ||
| bufferedChan chan *Event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ?
| bufferedChan chan *Event | ||
| errorsOccured []error | ||
| parsedCalendars []*Calendar | ||
| parsedEvents []*Event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ?
| p := new(Parser) | ||
| p.inputChan = make(chan string) | ||
| p.outputChan = make(chan *Event) | ||
| p.bufferedChan = make(chan *Event) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
This adds the ability to specify stdin as the source.