Allow setting the mininum macos version to target #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault Using the test binary as the "gobind" command not only avoids the overhead of recompiling the command, but also allows commands like "go test -race" to actually test the requested configuration of the command. Logging stderr and stdout separately — and logging only stderr by default — makes the failure messages much easier to spot. (Logging the combined output as before produced a massive wall of text that tends to bury the actual errors.) For golang/go#56292. Change-Id: Ia11fad19418d9b9004608c76fe512ceab4f247bc Reviewed-on: https://go-review.googlesource.com/c/mobile/+/443655 Run-TryBot: Bryan Mills <[email protected]> Reviewed-by: Hajime Hoshi <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: David Chase <[email protected]>
Also update to "go 1.17" to enable module graph pruning. For golang/go#56292. Change-Id: I1d1f4a2625d36d4c8587080e391d3e2c2e7f7808 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/443656 Run-TryBot: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Hajime Hoshi <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: David Chase <[email protected]>
Gobind utilizes golang.org/x/tools/go/packages.Load to find the directory of a package. Configure the load configuration to just find the list of files. Zero load mode is equivalent to combining NeedName+NeedFiles+NeedCompiledGoFiles bits. That is unnecessary, and can increase the chance of load failures. For example, load with the zero load mode may fail if all the necessary cgo dependencies aren't available in the system, but that shouldn't be critical for gobind's use case. Updates golang/go#56292 Change-Id: Ifaf4f43e9053cf4a43fd657a9a394fc13f611576 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/443935 Reviewed-by: David Chase <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Hajime Hoshi <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
This change makes building archive files for iOS concurrent for each architecture and each platform. The strategy is basically the same as my previous CL for Android: https://go.dev/cl/426274. This change also specifies GOMODCACHE explicitly when executing Go commands so that the existing cache is always used. The default GOMODCACHE is $GOPATH/pkg/mod, and this path varies when a temporary GOPATH is specified, which results in cold cache. Before this change (on my MacBook Pro 2020): $ time go run ./cmd/gomobile/ bind -target ios ./example/bind/hello/ real 0m23.274s user 0m15.751s sys 0m10.469s After this change: $ time go run ./cmd/gomobile/ bind -target ios ./example/bind/hello/ real 0m8.059s user 0m13.763s sys 0m9.004s Updates golang/go#37902 Updates golang/go#54770 Change-Id: Iaeb077b58c22ab63d28f78972a0af76660883a05 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/442195 Reviewed-by: Changkun Ou <[email protected]> Run-TryBot: Hajime Hoshi <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Change-Id: If63bcb8fd7610d0a052be5771062cbf4efc41355 GitHub-Last-Rev: 1739535 GitHub-Pull-Request: golang#83 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/429057 Auto-Submit: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Change-Id: Ia17aadf683b8e3e918e0490b9b3bf4f6ae48d813 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/472236 Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Run-TryBot: Hajime Hoshi <[email protected]>
marinthiercelin
force-pushed
the
feat/min-macos-version
branch
from
1305b3f to
f78ccd0
Compare
marinthiercelin
force-pushed
the
feat/min-macos-version
branch
from
f78ccd0 to
f77f444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.