Skip to content

Conversation

dkg
Copy link

@dkg dkg commented Jul 31, 2025

This is a step toward being able to support

gosop generate-key --signing-only

See ProtonMail/gosop#43

This is a step toward being able to support

    gosop generate-key --signing-only

See ProtonMail/gosop#43
@twiss
Copy link
Member

twiss commented Jul 31, 2025

Hey 👋 Thanks for the PR!

I'm a bit hesitant about adding a boolean option that starts with No, essentially making it backwards. Since sop already provides a name for this, how about we borrow from that and name this GenerateSigningKeyOnly or some such?

@dkg
Copy link
Author

dkg commented Jul 31, 2025

I agree that the sense inversion is pretty weird. I wanted it to default to false, so that there's nothing extra to do if the struct is 0-initialized. I don't mind naming it SigningOnly if you prefer, but i thought you might want some level of deeper control here (for example, enabling or disabling Authentication-capable subkeys).

If you prefer SigningOnly, i'm happy to revise.

Alternately, instead of adding a member to the struct, i guess we could augment NewEntity with another parameter (though that feels pretty clumsy in terms of API shift, and given golang's opposition to default parameters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants