Skip to content

Bump tibdex/github-app-token from 1.7.0 to 1.8.0 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Bump tibdex/github-app-token from 1.7.0 to 1.8.0 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a61a73
Added new custom fields (#2)
RuzannaAvetisyan Jan 18, 2023
126e8ce
Fixed integration
Jan 24, 2023
9e105c7
Fixes after review
Jan 25, 2023
c68afde
Fixes after review
Jan 25, 2023
83bc975
Bump tibdex/github-app-token from 1.7.0 to 1.8.0
dependabot[bot] Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/issue_tracker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
steps:
- name: Generate token
id: generate_token
uses: tibdex/github-app-token@021a2405c7f990db57f5eae5397423dcc554159c
uses: tibdex/github-app-token@b62528385c34dbc9f38e5f4225ac829252d1ea92
with:
app_id: ${{ secrets.ISSUE_APP_ID }}
private_key: ${{ secrets.ISSUE_APP_PEM }}
Expand Down
7 changes: 6 additions & 1 deletion modules/limelightDigitalBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,12 @@ function buildPlacement(bidRequest) {
type: bidRequest.params.adUnitType.toUpperCase(),
publisherId: bidRequest.params.publisherId,
userIdAsEids: bidRequest.userIdAsEids,
supplyChain: bidRequest.schain
supplyChain: bidRequest.schain,
custom1: bidRequest.params.custom1,
custom2: bidRequest.params.custom2,
custom3: bidRequest.params.custom3,
custom4: bidRequest.params.custom4,
custom5: bidRequest.params.custom5
}
}
}
14 changes: 12 additions & 2 deletions modules/limelightDigitalBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,12 @@ var adUnits = [{
params: {
host: 'exchange-9qao.ortb.net',
adUnitId: 0,
adUnitType: 'banner'
adUnitType: 'banner',
custom1: 'custom1',
custom2: 'custom2',
custom3: 'custom3',
custom4: 'custom4',
custom5: 'custom5'
}
}]
}];
Expand All @@ -40,7 +45,12 @@ var videoAdUnit = [{
params: {
host: 'exchange-9qao.ortb.net',
adUnitId: 0,
adUnitType: 'video'
adUnitType: 'video',
custom1: 'custom1',
custom2: 'custom2',
custom3: 'custom3',
custom4: 'custom4',
custom5: 'custom5'
}
}]
}];
Expand Down
40 changes: 35 additions & 5 deletions test/spec/modules/limelightDigitalBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ describe('limelightDigitalAdapter', function () {
host: 'exchange.ortb.net',
adUnitId: 123,
adUnitType: 'banner',
publisherId: 'perfectPublisher'
publisherId: 'perfectPublisher',
custom1: 'custom1',
custom2: 'custom2',
custom3: 'custom3',
custom4: 'custom4',
custom5: 'custom5'
},
placementCode: 'placement_0',
auctionId: '74f78609-a92d-4cf1-869f-1b244bbfb5d2',
Expand Down Expand Up @@ -49,7 +54,12 @@ describe('limelightDigitalAdapter', function () {
params: {
host: 'ads.project-limelight.com',
adUnitId: 456,
adUnitType: 'banner'
adUnitType: 'banner',
custom1: 'custom1',
custom2: 'custom2',
custom3: 'custom3',
custom4: 'custom4',
custom5: 'custom5'
},
placementCode: 'placement_1',
auctionId: '482f88de-29ab-45c8-981a-d25e39454a34',
Expand Down Expand Up @@ -90,7 +100,12 @@ describe('limelightDigitalAdapter', function () {
host: 'exchange.ortb.net',
adUnitId: 789,
adUnitType: 'video',
publisherId: 'secondPerfectPublisher'
publisherId: 'secondPerfectPublisher',
custom1: 'custom1',
custom2: 'custom2',
custom3: 'custom3',
custom4: 'custom4',
custom5: 'custom5'
},
placementCode: 'placement_2',
auctionId: 'e4771143-6aa7-41ec-8824-ced4342c96c8',
Expand Down Expand Up @@ -128,7 +143,12 @@ describe('limelightDigitalAdapter', function () {
params: {
host: 'exchange.ortb.net',
adUnitId: 789,
adUnitType: 'video'
adUnitType: 'video',
custom1: 'custom1',
custom2: 'custom2',
custom3: 'custom3',
custom4: 'custom4',
custom5: 'custom5'
},
placementCode: 'placement_2',
auctionId: 'e4771143-6aa7-41ec-8824-ced4342c96c8',
Expand Down Expand Up @@ -196,7 +216,12 @@ describe('limelightDigitalAdapter', function () {
'transactionId',
'publisherId',
'userIdAsEids',
'supplyChain'
'supplyChain',
'custom1',
'custom2',
'custom3',
'custom4',
'custom5'
);
expect(adUnit.id).to.be.a('number');
expect(adUnit.bidId).to.be.a('string');
Expand All @@ -205,6 +230,11 @@ describe('limelightDigitalAdapter', function () {
expect(adUnit.sizes).to.be.an('array');
expect(adUnit.userIdAsEids).to.be.an('array');
expect(adUnit.supplyChain).to.be.an('object');
expect(adUnit.custom1).to.be.a('string');
expect(adUnit.custom2).to.be.a('string');
expect(adUnit.custom3).to.be.a('string');
expect(adUnit.custom4).to.be.a('string');
expect(adUnit.custom5).to.be.a('string');
})
})
})
Expand Down