Skip to content

Conversation

@Nexengineer
Copy link
Contributor

No description provided.

@Nexengineer Nexengineer requested a review from a team as a code owner August 20, 2020 08:40
@Nexengineer Nexengineer added never merge only for reference Don't Merge labels Aug 20, 2020

<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<RootNamespace>In.ProjectEKA.DefaultHip</RootNamespace>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<RootNamespace>In.ProjectEKA.DefaultHip</RootNamespace>
<RootNamespace>In.ProjectEKA.NetworkHip</RootNamespace>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

hip-service.sln Outdated
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "In.ProjectEKA.HipServiceTest", "test\In.ProjectEKA.HipServiceTest\In.ProjectEKA.HipServiceTest.csproj", "{B5A9C0B9-25EC-472E-B2CD-3EC5A69584F7}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "In.ProjectEKA.DefaultHip", "src\In.ProjectEKA.DefaultHip\In.ProjectEKA.DefaultHip.csproj", "{23976B61-FBF9-41B8-AEA2-B70AD47F00A8}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "In.ProjectEKA.NetworkHip", "src\In.ProjectEKA.NetworkHip\In.ProjectEKA.NetworkHip.csproj", "{23976B61-FBF9-41B8-AEA2-B70AD47F00A8}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can call it FHIRHip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/In.ProjectEKA.FHIRHip/DataFlow/Collect.cs  3
- test/In.ProjectEKA.FHIRHipTest/DataFlow/CollectTest.cs  2
- src/In.ProjectEKA.FHIRHip/Link/PatientRepository.cs  1
- test/In.ProjectEKA.FHIRHipTest/Link/PatientRepositoryTest.cs  2
- src/In.ProjectEKA.FHIRHip/DataFlow/Model/DataFlowConfiguration.cs  1
- src/In.ProjectEKA.FHIRHip/DataFlow/Model/NetworkDataResponse.cs  1
- test/In.ProjectEKA.FHIRHipTest/Discovery/PatientMatchingRepositoryTest.cs  2
- src/In.ProjectEKA.FHIRHip/Discovery/Model/PatientConfiguration.cs  1
- src/In.ProjectEKA.FHIRHip/Discovery/PatientMatchingRepository.cs  1
- src/In.ProjectEKA.FHIRHip/DataFlow/Model/NetworkData.cs  1
- src/In.ProjectEKA.FHIRHip/DataFlow/Model/NetworkDataRequest.cs  1
- src/In.ProjectEKA.FHIRHip/Discovery/Model/PatientResponse.cs  1
- src/In.ProjectEKA.FHIRHip/Patient/FileReader.cs  1
- src/In.ProjectEKA.FHIRHip/Discovery/Model/PatientResponseResult.cs  1
- src/In.ProjectEKA.FHIRHip/DataFlow/CareContextRecord.cs  1
         

Clones added
============
- src/In.ProjectEKA.FHIRHip/DataFlow/Collect.cs  1
- test/In.ProjectEKA.FHIRHipTest/DataFlow/CollectTest.cs  7
- src/In.ProjectEKA.FHIRHip/Link/PatientRepository.cs  2
- test/In.ProjectEKA.FHIRHipTest/Link/PatientRepositoryTest.cs  6
- test/In.ProjectEKA.FHIRHipTest/Discovery/PatientMatchingRepositoryTest.cs  6
- src/In.ProjectEKA.FHIRHip/Discovery/PatientMatchingRepository.cs  2
         

See the complete overview on Codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Don't Merge never merge only for reference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants