Upstream Commits #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec is not clear on how to handle this. Three variations exist: ``` $ echo '' | /home/user/commonmark.js/bin/commonmark <p><img src="image.png" alt="text <textarea> text" /></p> $ echo '' | /home/user/cmark/build/src/cmark <p><img src="image.png" alt="text <textarea> text" /></p> $ echo '' | /home/user/.local/bin/commonmark <p><img src="image.png" alt="text text" /></p> ``` Prior to this commit: - when HTML tags are enabled, tags were removed (as in Haskell version) - when HTML tags are disabled, tags were escaped (as in C version) After this commit: - tags will be escaped (as in C version) regardless of HTML flag + render hardbreaks as newlines, same as cmark
* docs: replace `.js` with `.mjs` in links to files * docs: replace `.js` with `.mjs` in links to files
The spec update changes these things: * It simplifies the HTML regex so that `<!-- a -- b -->` is an HTML comment. HTML5 reports this as an error, but still parses it. * It changes the set of known HTML block elements to match HTML5, adding `search` and removing `source`. * It adds Unicode Symbols to the set of punctuation characters that are used to evaluate flankingness. This commit also changes the declaration HTML regex to match lowercase, even though that change was technically made in spec version 0.30.
Update to spec 0.31.2
* Add text_decoration tutorial doc * Add post-processing rule tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
30 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.