Skip to content

Add description metadata to model info #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add description metadata to model info #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b943e9c
Add description metadata to model info
RomanFenioux Oct 30, 2025
f42003e
Merge branch 'dev' into add-metadata-info
yiheng-wang-nv Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci/update_model_info_deparate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,11 @@ def update_model_info(
model_info = get_json_dict(model_info_path)

if bundle_name_with_version not in model_info.keys():
model_info[bundle_name_with_version] = {"checksum": "", "source": ""}
model_info[bundle_name_with_version] = {"checksum": "", "source": "", "description": ""}
Copy link
Collaborator

@yiheng-wang-nv yiheng-wang-nv Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RomanFenioux , this script is an old version and is not used, can you revert the changes? Thanks

Copy link
Author

@RomanFenioux RomanFenioux Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, i did not know that. Should the file be deleted to avoid confusion if the script is not used anymore ?


model_info[bundle_name_with_version]["checksum"] = checksum
model_info[bundle_name_with_version]["source"] = source
model_info[bundle_name_with_version]["description"] = metadata["description"]

save_model_info(model_info, model_info_path)
return (True, "update successful")
Expand Down
3 changes: 2 additions & 1 deletion ci/update_model_info_deparate_ngc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,11 @@ def update_model_info(

# step 4
if bundle_name_with_version not in model_info.keys():
model_info[bundle_name_with_version] = {"checksum": "", "source": ""}
model_info[bundle_name_with_version] = {"checksum": "", "source": "", "description": ""}

model_info[bundle_name_with_version]["checksum"] = checksum
model_info[bundle_name_with_version]["source"] = source
model_info[bundle_name_with_version]["description"] = metadata["description"]

save_model_info(model_info, model_info_path)
return (True, "update successful")
Expand Down