optimize schedule failure event

[Kyrie336]

What type of PR is this?

/kind feature

What this PR does / why we need it:

1. delete duplicate event type definition, use common package
2. support vendor device report custom event

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[gemini-code-assist]

Summary of Changes

Hello @Kyrie336, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the handling of scheduling failure events within the system. By centralizing the definitions of various failure reasons and introducing a new, flexible parsing utility, the changes aim to eliminate redundant code and enhance the system's capability to process and report custom events from vendor devices. This leads to a more modular, maintainable, and extensible scheduling component.

Highlights

• Centralized Event Definitions: Duplicate definitions for scheduling failure event types have been removed from pkg/scheduler/score.go and are now referenced from a common package, improving code consistency and maintainability.
• New Reason Parsing Utility: A new function, ParseReason, has been added to pkg/device/common/common.go. This utility allows for flexible parsing of formatted reason strings into a map of failure reasons and their counts, enhancing the ability to process custom vendor device events.
• Scheduler Logic Refactoring: The scheduler's scoring logic in pkg/scheduler/score.go has been updated to utilize the new ParseReason function and the centralized failure event constants, streamlining how scheduling failures are identified and logged.
• Comprehensive Testing: New unit tests have been added for the ParseReason function, and existing scheduler tests have been updated to reflect the use of the new common event definitions, ensuring the robustness of these changes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a good refactoring that centralizes schedule failure reasons into a common package, removing duplication and improving maintainability. It also introduces a new parser for the reason string. My review includes a couple of suggestions to improve the new parser function and its test coverage to make it more robust.

[codecov]

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/device/common/common.go	80.00%	1 Missing and 1 partial ⚠️

Flag	Coverage Δ
unittests	64.03% <88.23%> (+1.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/scheduler/score.go	92.37% <100.00%> (+0.31%)	⬆️
pkg/device/common/common.go	53.33% <80.00%> (+53.33%)	⬆️

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[archlitchi]

/lgtm

[hami-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, Kyrie336

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [archlitchi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment