Fix: After removing the device plugin from the gpu node, it can still be scheduled to this node

[luohua13]

What type of PR is this?
/kind bug

What this PR does / why we need it:

1. CheckHealth is always return true, true when removing the device plugin from the gpu node.
2. The scheduler component and plugin component continuously update different prefix values ​​for the hami.io/node-handshake key on the node annotations. The correct way is for the device plugin to update regularly and the scheduler component to check the status.

[hami-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: luohua13
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @luohua13, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug where GPU nodes could still be scheduled for device-dependent workloads even after their associated device plugin was removed. The solution involves refining the device plugin's health check mechanism by standardizing the hami.io/node-handshake annotation format and centralizing its management. This ensures that the scheduler accurately reflects the availability of devices on a node, preventing scheduling errors and improving overall resource management reliability.

Highlights

• Improved Device Plugin Health Check: The CheckHealth function now accurately determines the presence and health of device plugins, preventing nodes from being erroneously scheduled for devices that are no longer available after the plugin's removal.
• Standardized Handshake Annotation: The hami.io/node-handshake annotation value has been standardized to include a Requesting_ prefix and a precise time.DateTime formatted timestamp, which is crucial for reliable health status checks by the scheduler.
• Centralized Annotation Management: Global HandshakeAnnos and RegisterAnnos variables have been moved to a shared util package, ensuring consistent access and management across different components and reducing potential for discrepancies.
• Typo Correction: A minor typo in the RegistrInAnnotation function name has been corrected to RegisterInAnnotation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix a bug where nodes remain schedulable after a device plugin has been removed. The approach involves changing the handshake mechanism: the device plugin now periodically reports a 'Requesting' status with a timestamp. If this timestamp expires, the node is marked as unhealthy.

My review identifies a critical vulnerability in the CheckHealth function that could lead to a panic, and also points out that the original bug (node being schedulable with a missing handshake annotation) is not fully resolved. I've provided a code suggestion to make the function more robust by handling malformed or missing annotations correctly. I also recommend enhancing the test suite to cover these critical edge cases.

[archlitchi]

please pass the CI check