fix(worker): cleanup eth formatting #503
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes Ether amount formatting by replacing manual wei-to-ether conversions with the format_ether utility across provider operations, CLI commands, and an example.
- Imported and used
format_etherin place of manual division by 10^18. - Cleaned up various
Console::infoandprintln!calls for consistency.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| crates/worker/src/operations/provider.rs | Replaced manual wei division with format_ether in log messages. |
| crates/worker/src/cli/command.rs | Switched CLI output to use format_ether, added import and calls. |
| crates/dev-utils/examples/transfer_eth.rs | Updated example to format balances via format_ether. |
Comments suppressed due to low confidence (2)
crates/worker/src/operations/provider.rs:226
- [nitpick] The label "Balance" is ambiguous in the context of both token and ETH balances; consider making it more specific (e.g., "Token balance").
Console::info("Balance", &format_ether(balance));
crates/worker/src/operations/provider.rs:274
- [nitpick] This duplicate log also uses the generic label "Balance"; renaming it to distinguish token balance from ETH balance would improve clarity.
Console::info("Balance", &format_ether(balance));
| Console::info( | ||
| "ETH Balance", | ||
| &format!("{:.6} ETH", { f64::from(eth_balance) / 10f64.powf(18.0) }), | ||
| &format!("{} ETH", format_ether(U256::from(eth_balance))), |
There was a problem hiding this comment.
The U256::from(eth_balance) is redundant since eth_balance is already a U256; you can pass eth_balance directly to format_ether to simplify the code.
| &format!("{} ETH", format_ether(U256::from(eth_balance))), | |
| &format!("{} ETH", format_ether(eth_balance)), |
Copilot uses AI. Check for mistakes.
| Console::info( | ||
| "ETH Balance", | ||
| &format!("{:.6} ETH", { f64::from(eth_balance) / 10f64.powf(18.0) }), | ||
| &format!("{} ETH", format_ether(U256::from(eth_balance))), |
There was a problem hiding this comment.
Consider passing eth_balance directly to format_ether instead of wrapping it in U256::from, to reduce unnecessary conversions.
| &format!("{} ETH", format_ether(U256::from(eth_balance))), | |
| &format!("{} ETH", format_ether(eth_balance)), |
Copilot uses AI. Check for mistakes.
| "Required stake", | ||
| &format!("{}", required_stake / U256::from(10u128.pow(18))), | ||
| ); | ||
| Console::info("Required stake", &format_ether(required_stake).to_string()); |
There was a problem hiding this comment.
Calling .to_string() on the result of format_ether is redundant since it already returns a String; you can pass &format_ether(required_stake) directly.
| Console::info("Required stake", &format_ether(required_stake).to_string()); | |
| Console::info("Required stake", &format_ether(required_stake)); |
Copilot uses AI. Check for mistakes.
| @@ -879,7 +877,7 @@ pub async fn execute_command( | |||
| .await | |||
| .unwrap(); | |||
|
|
|||
| let format_balance = format!("{}", provider_balance / U256::from(10u128.pow(18))); | |||
| let format_balance = format_ether(provider_balance).to_string(); | |||
There was a problem hiding this comment.
The .to_string() here clones the string returned by format_ether; consider using the String directly to avoid an extra allocation.
| let format_balance = format_ether(provider_balance).to_string(); | |
| let format_balance = format_ether(provider_balance); |
Copilot uses AI. Check for mistakes.
No description provided.