Skip to content

imp(orchestrator): atomic operation on node group removal, ability to delete groups manually #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 15, 2025

Conversation

JannikSt
Copy link
Member

No description provided.

@JannikSt JannikSt requested a review from Copilot June 13, 2025 15:00
Copilot

This comment was marked as outdated.

@JannikSt JannikSt requested a review from Copilot June 13, 2025 15:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements atomic operations during node group removal and introduces a new API endpoint for manual group deletion while updating logging levels in the worker component.

  • Updated log directive levels for iroh-related modules from warn to error and added new directives for quinn modules.
  • Refactored Redis operations in node group creation and dissolution processes to use atomic transactions.
  • Added a new DELETE route for group deletion in the API.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crates/worker/src/utils/logging.rs Updated log levels for several modules to error to enforce stricter logging.
crates/worker/src/p2p/service.rs Refined console messages on successful compute pool registration.
crates/orchestrator/src/plugins/node_groups/mod.rs Replaced multiple Redis operations with atomic transactions in group creation/dissolution and made dissolve_group public.
crates/orchestrator/src/api/routes/groups.rs Added a new API endpoint to delete node groups manually.
Comments suppressed due to low confidence (2)

crates/worker/src/p2p/service.rs:530

  • [nitpick] The success message is now split across section, success, and info calls; consider adding a comment to clarify the rationale behind this formatting to maintain consistency in status reporting.
Console::section("WORKER JOINED COMPUTE POOL");

crates/worker/src/utils/logging.rs:78

  • Changing the log level from 'warn' to 'error' for iroh modules will filter out lower-severity logs; please confirm that this stricter logging is intentional and aligns with the overall logging strategy.
.add_directive("iroh=error".parse()?)

@JannikSt JannikSt merged commit cc4818f into develop Jun 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant