Pass python version to uv sync and run #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reverts the use of `python=False` in all nox sessions. Sessions for tests, linting, and formatting will use nox virtual environments. In these sessions the location of the virtual environment will be passed to `uv run` and `uv sync`. This means uv will use the python version that nox is executed with. This change is needed because nox correctly masks all environment variables when starting a `session.run` or `session.run_install`. This is ideal to maintain repeatable behavior. This is not ideal when attempting to use `UV_PYTHON` to control which version is being run. Enforcing that uv use the python version that nox is executed with is the least surprising behavior. Even if this ignores the `.python-version` file in the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reverts the use of
python=Falsein all nox sessions.Sessions for tests, linting, and formatting will use nox virtual
environments. In these sessions the location of the virtual environment
will be passed to
uv runanduv sync. This means uv will use thepython version that nox is executed with.
This change is needed because nox correctly masks all environment
variables when starting a
session.runorsession.run_install. Thisis ideal to maintain repeatable behavior. This is not ideal when
attempting to use
UV_PYTHONto control which version is being run.Enforcing that uv use the python version that nox is executed with is
the least surprising behavior. Even if this ignores the
.python-versionfile in the repo.