This repository was archived by the owner on Mar 21, 2022. It is now read-only.
Update to 0.6.13 in stable branch #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace it with the new plank texture
…karounds are active to the instance log
…eForge for user displayed strings
NOISSUE disable datapacks button in the world screen if no world is selected
NOISSUE print information about whether the system GLFW or OpenAL workarounds are active to the instance log
NOISSUE fix MOC warning complaining about an unused MOC file include
NOISSUE rename Twitch to flame internally for consistency and to CurseForge for user displayed strings
…multiple right now these are unused anyway
Disable qt 5.6 DPI scaling and use windows' builtin DPI scaling, which works much better on multi-monitor setups
This resolves an issue with the modpacks.ch search functionality, in which a search issued while one is currently in progress won't be made and the UI won't allow for the search to be made after. Reproduction Steps: 1. Open the FTB pane in the Add Instance Dialog 2. Perform a search while MMC is still performing the initial search The search won't be performed, the existing search will have been aborted, and you are unable to try the search again (without trying a different search in the meantime). This was caused by 2 things: 1. A search cannot be re-attempted, and this logic doesn't consider failures. 2. The failure slot wasn't called when the NetJob was aborted, so the search would never be performed - but the term would be stored as if it had (trigering point 1). I have resolved this by doing 2 things: 1. If the failure slot is called, set a searchState of Failed. Allow search re-attempts in this case. 2. If there is a present NetJob, abort and reset it. The immediately continue with the search.
MultiMCGH-3633 assume latest MC version, if CurseForge pack supports multiple
MultiMCGH-3666 Fix multi-monitor dpi scaling on windows
NOISSUE Fix edgecase where new searches won't be processed
This reverts commit 34bf688.
This will remove support for macOS 10.7 and 10.8, but their numbers in analytics are 0
update UI to match other modpack platforms add sorting add version selection, fixes MultiMCGH-3667 add installing beta versions, fixes MultiMCGH-3611
Presumably this is caused by the bump to GCC 11 in Fedora 34. See
the error that did occur below...
./MultiMC5/application/KonamiCode.cpp: In member function ‘void KonamiCode::input(QEvent*)’:
./MultiMC5/application/KonamiCode.cpp:38:23: error: comparison of integer expressions of different signedness: ‘int’ and ‘std::array<Qt::Key, 10>::size_type’ {aka ‘long unsigned int’} [-Werror=sign-compare]
38 | if(m_progress == konamiCode.size())
| ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
Add flat icon for custom-commands
It has not been touched in a long time. This brings it a bit more up to date.
It is unstable for reasons unknown.
It's never going to work with Qt 5.6, so there's no point. People need to update.
Add custom-commands icon for other themes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a rebase on MultiMC/Launcher@e2355eb (tag 0.6.13 stable branch)
It builds an runs fine on windows for me using clang and Microsoft's libc. But this version should also run just fine with the setup recommeded in BUILD.md (mingw).
Being a rebase it has to be pushed with git push --force.
If you want to try and compile with clang you need to use the "stable-clang" branch in my fork