Skip to content

Fix #32 - Parent resizable fails to receive resize notification when under shadow DOM. #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #32 - Parent resizable fails to receive resize notification when under shadow DOM. #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions iron-resizable-behavior.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,13 @@
return;
}

// NOTE(cdata): In ShadowDOM, event retargeting makes echoing of the
// otherwise non-bubbling event "just work." We do it manually here for
// the case where Polymer is not using shadow roots for whatever reason:
if (!Polymer.Settings.useShadow) {
this._fireResize();
// NOTE(cdata): "Don't need to trigger event manually in case of ShadowDOM is used and
// event is coming from local DOM because of event retargeting. Otherwise, we need to trigger it manually".
if (Polymer.Settings.useShadow && event.target.domHost === this) {
return;
}

this._fireResize();
},

_fireResize: function() {
Expand Down