Minestom Latest - Update #499
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated method names to new documentation and changed minestom versioning. - Paper Build version was changed as I had issues building at all with the snapshot version. So it was changed to a generic version but everything still builds fine.
ckyuri
requested review from
dfsek,
solonovamax,
duplexsystem and
justaureus
as code owners
Bloeckchengrafik
approved these changes
Apr 12, 2025
…ing issues to load the world. EntityType.fromId(Integer.parseInt(id)); to delegate = EntityType.fromKey(id);
duplexsystem
requested changes
Apr 12, 2025
platforms/minestom/src/main/java/com/dfsek/terra/minestom/MinestomPlatform.java
Outdated
Show resolved
Hide resolved
…ng pulling functionality out of a common existing function
|
I would like to add I was not able to get working version of a snapshot on my end (even those listed on the paper repository) so I have opted to revert to the one you had originally on this branch. The minestom build is able to be built successfully on a generic but I imagine there would be no sideeffects of a snapshot build being used either. I simply could not get a snapshot build working on my end so I avoided it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Changelog
Checklist
Mandatory checks
ver/prefix)or is a branch that is intended to be merged into a version branch.
CONTRIBUTING.mddocument in the root of the git repository.
Types of changes
Compatibility
Documentation
Testing
Licensing
release it under GPLv3.
released under GPLv3 or a compatible license.