Add record batch adapter to zero-copy stream record batches into csp #541
+743
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhamchopra
force-pushed
the
ac/record_batch_adapter
branch
2 times, most recently
from
643546c to
395a316
Compare
AdamGlustein
reviewed
Jun 4, 2025
Signed-off-by: Arham Chopra <[email protected]>
arhamchopra
force-pushed
the
ac/record_batch_adapter
branch
2 times, most recently
from
807ad9a to
367c4ef
Compare
Signed-off-by: Arham Chopra <[email protected]>
arhamchopra
force-pushed
the
ac/record_batch_adapter
branch
from
367c4ef to
4fb539d
Compare
arhamchopra
requested review from
robambalu,
svatasoiu,
alexddobkin,
ptomecek and
timkpaine
as code owners
AdamGlustein
requested changes
Jun 15, 2025
Signed-off-by: Arham Chopra <[email protected]>
AdamGlustein
approved these changes
Jun 16, 2025
There was a problem hiding this comment.
Looks good, all comments addressed. Wait for @robambalu to take a final look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.