Questionnaire: All branching shown in View your response

[toanlamt]

Context: Enable the "Allow branching questions" setting. Create a radio question with multiple options, and add corresponding dependency questions for each option. The issue occurs when users answer the question and view their responses.

Actual Results: Users can see all of the dependency questions, which can be overwhelming.

Expected Results: Users should only see the dependency question that corresponds to the option they selected.

Impacted Areas: This fix only impacts the "View your response(s) > Individual responses" page.

[mchurchward]

See inline comment

[tailetan]

@mchurchward I have just pushed a new commit to fix your comment. Please review again. Thanks.

[mchurchward]

This change does not seem to be working correctly.
I created dependencies, similar to the what is in the provided Behat test.

1. Do you own a car yes/no
   2.1) Yes - What colour is you car?
   2.2) No - Will you buy a car this year?

If I answer "No" to question 1, my individual response shows the first dependency (colour) faded out with no answer, but not the second dependency answer which is the one I answered. See image:

[tailetan]

@mchurchward, I have just tested that case, but it works as expected.

See the video:
https://github.com/user-attachments/assets/e4acf931-0b49-41b6-a1ce-6d38db0de617
Did you set the dependencies correctly?

[mchurchward]

@mchurchward, I have just tested that case, but it works as expected.

See the video: https://github.com/user-attachments/assets/e4acf931-0b49-41b6-a1ce-6d38db0de617 Did you set the dependencies correctly?

Your video shows the "Yes" reply. The problem I posted is when "No" is answered.

Please review my image above again. I answered "no". I should see the "Will you buy a car this year", not "What colour is your car".

[tailetan]

@mchurchward yes, i also tested with no option. Please refer to the below attachment:
https://github.com/user-attachments/assets/a7bad7a0-bfd6-4578-8658-979b2bc8d46d

Setting

[mchurchward]

I still see the issue when I do the same.

Here is the question setup:

Here are my answers:

And here is what I see on the response screen:

Note that this a new questionnaire with only one respondent.

If I add a second response where I answer "yes", the response display looks fine for the new response, but the first one still is wrong.

Something to check is that you are testing with exactly the same code as this PR, and that you don't have other changes that are not in MOODLE_404_STABLE or your PR?

[mchurchward]

I added a Behat test to test the specific case above.
It fails the Behat as well.

[toanlamt]

Hi @mchurchward

Thanks for the feedback. I've reviewed my commit and investigated the issue. It turns out the problem was related to the logic that checks eligibility for the question. I've fixed it and pushed a new commit. Could you please review it again?