ControllerCompositeDisposable: safer post-dispose behavior #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During
Dispose()method, the composite enumerates its internal list. If a client adds a disposable at that time, the list is mutated and we get:InvalidOperationException: Collection was modified; enumeration operation may not execute.Root cause
Add/AddRangemethods continued to push into the internal list after disposal had begun.Fix
If the composite is disposed,
Add/AddRangedispose the incoming item(s) immediately.Notes